Fix bug for opdettype in light propagation time #898
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrylay97
reviewed
Jan 20, 2026
Member
henrylay97
left a comment
henrylay97
left a comment
There was a problem hiding this comment.
Thanks for acting so quick Alejandro. Just a couple of queries before I wave this through :D
Comment on lines
39
to
43
| if(fPDSMap.pdType(opch)=="pmt_coated") fOpDetType.push_back(0); | ||
| else if(fPDSMap.pdType(opch)=="pmt_uncoated") fOpDetType.push_back(1); | ||
| else if(fPDSMap.pdType(opch)=="xarapuca_vuv") fOpDetType.push_back(2); | ||
| else if(fPDSMap.pdType(opch)=="xarapuca_vis") fOpDetType.push_back(3); | ||
| else fOpDetType.push_back(-1); |
Member
There was a problem hiding this comment.
A couple of questions:
- Given this is only used in one place, is it worth having this vector? Could just have the if statements directly query the
fPDSMap.pdType. - If you are keeping the vector setup, is it worth defining the numbers as an enum in the header file?
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback! I've sticked to using fPDSMap which also allows for straightforward integration of the XAs (although they are not being reconstructed for the moment)
sbndcode/LightPropagationCorrection/LightPropagationCorrection_module.cc
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Could you have a look at this @fjnicolas ? We would like to have it in this week's release :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a minor bug on the light propagation correction module spotted by @henrylay97. Previously, the minimum of VIS and VUV light propagation time was assigned to both coated and uncoated channels. Now uncoated channels always receive the VIS light propagation time. The impact of the bug was expected to be minimal since uncoated channels hardly every contribute to the OpFlash timing estimation.
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
Link(s) to docdb describing changes (optional)
Is there a docdb describing the issue this solves or the feature added?